Skip to content

feat: enhance globe animation and add grid line rotation #2294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Abhishek-Punhani wants to merge 2 commits into from
Closed

feat: enhance globe animation and add grid line rotation #2294

Abhishek-Punhani wants to merge 2 commits into from

Conversation

@Abhishek-Punhani
Copy link
Contributor

@Abhishek-Punhani Abhishek-Punhani commented Dec 23, 2025

Description

Update NetworkGlobe animation to implement orbital rotation

  • Animation looks cleaner after adding these changes. The clusters now revolve around the central node, rather than remaining static relative to the background, providing a more dynamic representation of the KubeStellar network topology.

Related Issue

Fixes #2293

Changes Made

  • Updated NetworkGlobe.tsx

Checklist

Please ensure the following before submitting your PR:

  • I have reviewed the project's contribution guidelines.
  • I have written unit tests for the changes (if applicable).
  • I have updated the documentation (if applicable).
  • I have tested the changes locally and ensured they work as expected.
  • My code follows the project's coding standards.

Screenshots or Logs (if applicable)

Screencast.from.12-23-2025.03.46.32.PM.webm

Additional Notes

Copilot AI review requested due to automatic review settings December 23, 2025 10:18
@kubestellar-prow
Copy link

kubestellar-prow bot commented Dec 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign btwshivam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow
Copy link

kubestellar-prow bot commented Dec 23, 2025

Hi @Abhishek-Punhani. Thanks for your PR.

I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-prow kubestellar-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 23, 2025
Copilot AI reviewed Dec 23, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the NetworkGlobe animation by implementing orbital rotation for cluster nodes around the central node and synchronizing grid line rotation with the globe. The implementation adds rotation to a new group containing clusters and increases animation speeds across multiple elements.

Key Changes:

  • Added orbital rotation for clusters around the central node using a new rotating group wrapper
  • Synchronized grid line rotation with the globe rotation for better visual cohesion
  • Increased animation speeds and added z-axis rotation to various elements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Abhishek-Punhani
changing speed based on feedback
66b2f64 
Signed-off-by: Abhishek-Punhani <[email protected]>
@Arpit529Srivastava
Copy link
Member

Arpit529Srivastava commented Dec 30, 2025

/cc @btwshivam

@kubestellar-prow kubestellar-prow bot requested a review from btwshivam December 30, 2025 17:45
@btwshivam
Copy link
Contributor

btwshivam commented Jan 2, 2026

@Abhishek-Punhani i reduded the globe line intentionally.. beacase of perfomace issue. our plan is to remove animation from login and cluster table too.. its too heavy

@btwshivam
Copy link
Contributor

btwshivam commented Jan 2, 2026

Crete a issue for both and in that issue we want design before to procedd to code. @Arpit529Srivastava you can open issue too.. mention we want creative design before implemtion. for cluster visualation using icons will be good enough

@btwshivam
Copy link
Contributor

btwshivam commented Jan 2, 2026

/close

@kubestellar-prow kubestellar-prow bot closed this Jan 2, 2026
@kubestellar-prow
Copy link

kubestellar-prow bot commented Jan 2, 2026

@btwshivam: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-project-automation github-project-automation bot moved this from In Progress to Done in KubeStellar UI Project Jan 2, 2026
@Abhishek-Punhani Abhishek-Punhani mentioned this pull request Jan 3, 2026
Open
@Arpit529Srivastava
Copy link
Member

Arpit529Srivastava commented Jan 4, 2026

Crete a issue for both and in that issue we want design before to procedd to code. @Arpit529Srivastava you can open issue too.. mention we want creative design before implemtion. for cluster visualation using icons will be good enough

I think @Abhishek-Punhani has already opened issue regarding this. #2314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@btwshivam btwshivam Awaiting requested review from btwshivam

Assignees

No one assigned

Labels

frontend needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

KubeStellar UI Project
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improving Login Page Globe Animation

3 participants

@Abhishek-Punhani @Arpit529Srivastava @btwshivam